RFR: JDK-8077371: Binary files in JAXP test should be removed [v9]
Roger Riggs
rriggs at openjdk.org
Fri Oct 13 16:26:57 UTC 2023
On Fri, 13 Oct 2023 12:21:28 GMT, Mahendra Chhipa <mchhipa at openjdk.org> wrote:
>> Test is updated to create the binary files during test execution.
>
> Mahendra Chhipa has updated the pull request incrementally with one additional commit since the last revision:
>
> Tests with base64 input are removed.
test/jdk/javax/xml/jaxp/datatype/8033980/GregorianCalAndDurSerDataTemplate.java line 28:
> 26: */
> 27: public class GregorianCalAndDurSerDataTemplate {
> 28: public static final String GREGO_CAL_DUR_SER_CLASS = "public class %sGregorianCalendarAndDurationSerData extends GregorianCalendarAndDurationSerData {\n" +
These files should have a comment indicating they are generated and should not be edited.
And to avoid any manual steps, should include the full copyright with the year generated.
Like:
// -- This file was mechanically generated: Do not edit! -- //
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13537#discussion_r1358483378
More information about the core-libs-dev
mailing list