RFR: 8318072: DonwcallLinker does not acquire/release segments in interpreter

Eirik Bjorsnos duke at openjdk.org
Fri Oct 13 18:46:08 UTC 2023


On Fri, 13 Oct 2023 08:00:07 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:

> Implement missing by-reference argument acquire/release functionality in DowncallLinker::invokeInterpBindings.
> 
> I've also simplified the related code a bit:
> - `retIndexMap` was not used. I've removed it
> - `BindingInterpreter.StoreFunc::store`'s type argument was not used. Removed
> - UpcallLinker was redundantly collecting the move bindings for return values. Removed
> 
> I've added runs without specialization to the failing tests as well, so that we keep testing this.
> 
> Testing: `jdk_foreign` suite.

DowncallLinker is not spelled correctly in the PR and JBS issue. Fixing this could improve searchability.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/16177#issuecomment-1762026584


More information about the core-libs-dev mailing list