RFR: 8318124: JFR: Rewrite instrumentation to use Class-File API [v2]

Erik Gahlin egahlin at openjdk.org
Mon Oct 16 05:07:42 UTC 2023


> Hi,
> 
> Could I have a review of an enhancement that replaces the use of ASM with the new Class-File API. This change only deals with bytecode that writes event data into buffers. Bytecode transformations carried out by classes in jdk.jfr.internal.intrument package are kept as is. Plan is to try to replace those with events in java.base.
> 
> To simplify the review process, I have tried to keep the code in the classes EventInstrumentation and EventClassBuilder similar to what existed before. Further refactorizations may happen at a later stage. 
> 
> Testing: tier1-3 + jdk/jdk/jfr
> 
> Thanks
> Erik

Erik Gahlin has updated the pull request incrementally with one additional commit since the last revision:

  Updates

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/16195/files
  - new: https://git.openjdk.org/jdk/pull/16195/files/cac2e347..ba96d273

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=16195&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=16195&range=00-01

  Stats: 31 lines in 3 files changed: 6 ins; 9 del; 16 mod
  Patch: https://git.openjdk.org/jdk/pull/16195.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/16195/head:pull/16195

PR: https://git.openjdk.org/jdk/pull/16195


More information about the core-libs-dev mailing list