RFR: 8318124: JFR: Rewrite instrumentation to use Class-File API [v2]

Erik Gahlin egahlin at openjdk.org
Mon Oct 16 06:11:58 UTC 2023


On Mon, 16 Oct 2023 05:56:00 GMT, Chen Liang <liach at openjdk.org> wrote:

>> I could not get it to work with findAttribute. No annotations were found.
>
> The existing code will silently finish the loop no-op and return `null` if no RVAA is present. So if `findAttribute` returns `Optional.empty()`, you should just return `null` to match the old behavior.

I added logging, and from what I could see, findAttribute always returned Optional.empty().

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16195#discussion_r1360154968


More information about the core-libs-dev mailing list