RFR: 8315585: Optimization for decimal to string [v6]

[Claes Redestad]

On Fri, 13 Oct 2023 17:01:11 GMT, Shaojin Wen <duke at openjdk.org> wrote:

>> I submitted PR #15555 before, and there were too many changes. I split it into multiple PRs with small changes. This one is one of them.
>> 
>> this PR removed the duplicate code for getChars in BigDecimal#StringBuilderHelper, i also make performance faster.
>> Please review and don't hesitate to critique my approach and patch.
>
> Shaojin Wen has updated the pull request incrementally with one additional commit since the last revision:
> 
>   use % calculate lowInt

I'd say go with the `makeConcatWithConstants` branch and file a follow-up to determine why it's intermittently slower and try to fix that. Chances are this is a fluke, or it's a symptom of an issue that would be good to analyze more in-depth. We shouldn't pick an implementation that is worse maintenance-wise just because it currently wins over cleaner, more idiomatic code but view that as a call to arms to improve the idiomatic case.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/16006#issuecomment-1764465071