RFR: 8316704: Regex-free parsing of Formatter and FormatProcessor specifiers [v13]

Shaojin Wen duke at openjdk.org
Mon Oct 16 13:18:14 UTC 2023


On Thu, 28 Sep 2023 15:01:25 GMT, Raffaello Giulietti <rgiulietti at openjdk.org> wrote:

>> Shaojin Wen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Refactor according to rgiulietti's suggestion and add testcases
>
> Meaningful external reviews take a _lot_ of engineering time on such a popular platform as the JDK.
> They make sense only on somehow stable code, otherwise they are a waste of human resources.
> 
> So sure, take your time to stabilize your code, make your tests, but please refrain from keep on changing too much once you publish a PR. If reviewers have to face continuous changes, they might become uninterested in reviewing.

@rgiulietti can you help me continue to review this PR?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/15776#issuecomment-1764464777


More information about the core-libs-dev mailing list