RFR: 8318180: Memory model reference from foreign package-info is broken

Maurizio Cimadamore mcimadamore at openjdk.org
Mon Oct 16 16:59:46 UTC 2023


On Mon, 16 Oct 2023 16:19:41 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

> This PR fixes a wrong reference to the JLS memory model section.

The broken reference seems to have originated from a bogus [edit](https://github.com/openjdk/panama-foreign/pull/751/files/4c4928d6c891132face4b78e702bbb611f6a67a3..4661d30bc0aae3fa7c58792eb7545bea0b3da527) to a section that used to be present:


* @apiNote The normal Java Object access control, guarantees and constraints, for example stated in
 * {@jls 6.6} and {@jls 10.4}, do not apply when accessing native memory segments as these segments are
 * backed by off-heap regions of memory.
 ```

Accidentally, ` normal Java Object access control, guarantees and constraints,` was replaced to reference memory model (following a CSR comment). But the old JLS reference stayed, leading to this issue.

We could, if desired, also keep the old references (and text!) too - but IMHO it is a bit confusing to be talking about access control when mentioning access to off-heap memory, so maybe it would be better to leave those out?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/16204#issuecomment-1764895796


More information about the core-libs-dev mailing list