RFR: 8317545: AIX PPC64: Implementation of Foreign Function & Memory API [v3]

Mon Oct 16 19:27:48 UTC 2023

On Mon, 16 Oct 2023 15:54:12 GMT, Martin Doerr <mdoerr at openjdk.org> wrote:

> I have filed a subtask to handle the tests: https://bugs.openjdk.org/browse/JDK-8318175 This PR is now compatible with "#pragma align (natural)", but permits layouts according to the default setting. This allows writing Java code which calls any library which was built with either option.

Supporting both seems like the best solution to me. The spec of Linker will need to be updated to allow for the packed variant as well.

> The developer needs to know which layout to use. (I guess it will be a very rare issue.) 

This seems fine to me. For linking in general, the developer is already expected to know what the right descriptor is. We try to do as much checking as possible to look for descriptors that don't make sense, or which the CallArrangers do not support (hence packed structs are currently rejected), but we can not check everything.

>  Changes related to how we handle object layouts could still be done by IBM in follow-up issues.

Ok. I'm assuming there are currently some failing tests due to the mismatch in ABI? (assuming the test libraries are compiled for the packed ABI)

-------------

PR Comment: https://git.openjdk.org/jdk/pull/16179#issuecomment-1765135912