RFR: 8303525: Refactor/cleanup open/test/jdk/javax/rmi/ssl/SSLSocketParametersTest.java [v3]

Mark Sheppard msheppar at openjdk.org
Tue Oct 17 09:00:26 UTC 2023


On Tue, 17 Oct 2023 00:02:28 GMT, Stuart Marks <smarks at openjdk.org> wrote:

>> Matthew Donovan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   retained a reference to the RMI server and improved naming
>
> test/jdk/javax/rmi/ssl/SSLSocketParametersTest.java line 81:
> 
>> 79:                 0, new SslRMIClientSocketFactory(), serverSocketFactory);
>> 80:         HelloClient client = new HelloClient();
>> 81:         client.runClient(stub);
> 
> You could even inline HelloClient here, as I don't think that having a separate class is actually doing anything..

it does emphasize the classic RMI client/server scenario!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14932#discussion_r1361765127


More information about the core-libs-dev mailing list