RFR: 8318363: Foreign benchmarks fail to build on some platforms [v2]

Aleksey Shipilev shade at openjdk.org
Wed Oct 18 08:30:41 UTC 2023


On Wed, 18 Oct 2023 03:54:17 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:

>> Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Use jlong.h
>
> test/micro/org/openjdk/bench/java/lang/foreign/libToCString.c line 24:
> 
>> 22:  */
>> 23: 
>> 24: #include <jlong_md.h>
> 
> I think you just want `jlong.h` here? AFAIK the `jlong_md.h` is the platform specific implementation file, whereas `jlong.h` is the 'interface'.
> 
> (though, `jlong.h` just includes `jlong_md.h` so it probably doesn't really matter in practice)

Right. I copy-pasted from some other file that includes `jlong_md.h` instead of `jlong.h`. For cleanliness reasons, we should of course include `jlong.h`. Fixed in new commit.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16228#discussion_r1363461316


More information about the core-libs-dev mailing list