RFR: 8254693: Add Panama feature to pass heap segments to native code [v2]

Jorn Vernee jvernee at openjdk.org
Wed Oct 18 10:27:28 UTC 2023


On Wed, 18 Oct 2023 09:58:12 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> I'm considering to leave `As such, these temporary addresses...` out. You already said that the address "is valid for the duration of the call". I'm not sure the subsequent sentence adds much. If you want to make a concrete example of something that should not be done, that would be better. But it seems to me that the client is as in charge as this text suggests - (e.g. if a native lib decides to hold onto an address, the client can't do much about it).
>
> So, summing up - either we write more and spell what are the things to be on the lookout for, or we leave it out.

Ok, I'll remove the second sentence.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16201#discussion_r1363628571


More information about the core-libs-dev mailing list