RFR: 8318598: FFM stylistic cleanups
Maurizio Cimadamore
mcimadamore at openjdk.org
Fri Oct 20 14:04:36 UTC 2023
On Fri, 20 Oct 2023 13:35:59 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:
> Port over stylistic changes from the panama-foreign repo. The following PRs are included:
>
> - https://github.com/openjdk/panama-foreign/pull/863
> - https://github.com/openjdk/panama-foreign/pull/888
> - https://github.com/openjdk/panama-foreign/pull/889
> - https://github.com/openjdk/panama-foreign/pull/893
> - https://github.com/openjdk/panama-foreign/pull/894
> - https://github.com/openjdk/panama-foreign/pull/897
> - https://github.com/openjdk/panama-foreign/pull/906
>
> Testing: `jdk_foreign`
Looks good
src/java.base/share/classes/jdk/internal/foreign/SegmentFactories.java line 86:
> 84: ensureInitialized();
> 85: Objects.requireNonNull(arr);
> 86: long byteSize = (long)arr.length * Utils.BaseAndScale.BYTE.scale();
Thanks for fixing up those
-------------
Marked as reviewed by mcimadamore (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/16286#pullrequestreview-1690113999
PR Review Comment: https://git.openjdk.org/jdk/pull/16286#discussion_r1367017251
More information about the core-libs-dev
mailing list