RFR: 8318598: FFM stylistic cleanups

[Alan Bateman]

On Fri, 20 Oct 2023 13:35:59 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:

> Port over stylistic changes from the panama-foreign repo. The following PRs are included:
> 
> - https://github.com/openjdk/panama-foreign/pull/863
> - https://github.com/openjdk/panama-foreign/pull/888
> - https://github.com/openjdk/panama-foreign/pull/889
> - https://github.com/openjdk/panama-foreign/pull/893
> - https://github.com/openjdk/panama-foreign/pull/894
> - https://github.com/openjdk/panama-foreign/pull/897
> - https://github.com/openjdk/panama-foreign/pull/906
> 
> Testing: `jdk_foreign`

src/java.base/share/classes/jdk/internal/foreign/AbstractMemorySegmentImpl.java line 635:

> 633:                             int elementCount) {
> 634: 
> 635:         var dstInfo = Utils.BaseAndScale.of(dstArray);

This is a case where I personally wouldn't use `var` because RHS is not clear, I have no idea what type dstInfo is.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16286#discussion_r1367209975