RFR: 8311877: [macos] Add CLI options to provide signing identity directly to codesign and productbuild [v3]

Alexey Semenyuk asemenyuk at openjdk.org
Fri Oct 20 16:33:39 UTC 2023


On Fri, 20 Oct 2023 04:23:56 GMT, Alexander Matveev <almatvee at openjdk.org> wrote:

>> Alexander Matveev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8311877: [macos] Add CLI options to provide signing identity directly to codesign and productbuild [v2]
>
> Yes, you got it right. I agree it does not make sense to consider error if `--mac-sign` is not specified. I fixed it as you suggested. `--mac-app-image-sign-identity` will be ignored and no signing is done if `--mac-sign` is not specified.
> 
> Also, updated `SigningPackageTest.java` to include tests for cases when only app-image is being signed or when only pkg is being signed using sign identity options.

@sashamatveev would you comment on Michael Hall's ide about codesign verification idea?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/16085#issuecomment-1773044912


More information about the core-libs-dev mailing list