RFR: 8317846: Typo in API documentation of classes IdentityHashMap [v2]

Jaikiran Pai jpai at openjdk.org
Mon Oct 23 06:29:35 UTC 2023


On Wed, 11 Oct 2023 05:29:22 GMT, ANUPAM DEV <duke at openjdk.org> wrote:

>> Hello,
>> 
>> I have fixed the typo in the comment for the constructor IdentityHashMap(Map<? extends K,? extends V> m)
>> 
>> before: Constructs a new identity hash map containing the keys-value mappings in the specified map.
>> after: Constructs a new identity hash map containing the key-value mappings in the specified map.
>> 
>> Please review the change.
>> 
>> Regards,
>> Anupam
>
> ANUPAM DEV has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Reverted the Copyright year to 2022

Given that the rest of the javadoc in this class uses the term `key-value` at various places, this indeed looks like a typo.

The change looks good to me.

Please update the copyright year on this file to:

> Copyright (c) 2000, 2023, Oracle ....

-------------

Marked as reviewed by jpai (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/16134#pullrequestreview-1691785082
PR Comment: https://git.openjdk.org/jdk/pull/16134#issuecomment-1774511647


More information about the core-libs-dev mailing list