RFR: JDK-8318476: Add resource consumption note to BigInteger and BigDecimal [v2]

Raffaello Giulietti rgiulietti at openjdk.org
Mon Oct 23 09:58:37 UTC 2023


On Mon, 23 Oct 2023 09:55:16 GMT, Raffaello Giulietti <rgiulietti at openjdk.org> wrote:

>> Joe Darcy has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Respond to review feedback.
>
> src/java.base/share/classes/java/math/BigInteger.java line 127:
> 
>> 125:  * the input. For example, a method like {@link intValue()} would be
>> 126:  * expected to run in <i>O</i>(1), that is constant time, since with
>> 127:  * the current internal reprentation only a fixed-size component of
> 
> Suggestion:
> 
>  * the current internal representation only a fixed-size component of

LGTM

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16298#discussion_r1368415466


More information about the core-libs-dev mailing list