RFR: 8317678: Fix up hashCode() for ZipFile.Source.Key [v9]

Alan Bateman alanb at openjdk.org
Mon Oct 23 10:27:39 UTC 2023


On Mon, 23 Oct 2023 09:14:06 GMT, Sean Coffey <coffeys at openjdk.org> wrote:

>> Fix up java.util.zip.ZipFile$Source hashCode() impl so that duplicate Source objects aren't created for the same zip file.
>
> Sean Coffey has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Update code comments

The update to ZipFile.Key hashCode and the Key comments look good. I don't have time to study the test but I think Lance and Jai are looking at that.

-------------

Marked as reviewed by alanb (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/16115#pullrequestreview-1692203826


More information about the core-libs-dev mailing list