Integrated: 8318124: JFR: Rewrite instrumentation to use Class-File API

Erik Gahlin egahlin at openjdk.org
Mon Oct 23 16:03:46 UTC 2023


On Sun, 15 Oct 2023 20:20:48 GMT, Erik Gahlin <egahlin at openjdk.org> wrote:

> Hi,
> 
> Could I have a review of an enhancement that replaces the use of ASM with the new Class-File API. This change only deals with bytecode that writes event data into buffers. Bytecode transformations carried out by classes in jdk.jfr.internal.intrument package are kept as is. Plan is to try to replace those with events in java.base.
> 
> To simplify the review process, I have tried to keep the code in the classes EventInstrumentation and EventClassBuilder similar to what existed before. Further refactorizations may happen at a later stage. 
> 
> Testing: tier1-3 + jdk/jdk/jfr
> 
> Thanks
> Erik

This pull request has now been integrated.

Changeset: 69c0ae23
Author:    Erik Gahlin <egahlin at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/69c0ae23a323dd547f53234848f32ed9ba41792b
Stats:     1178 lines in 12 files changed: 429 ins; 399 del; 350 mod

8318124: JFR: Rewrite instrumentation to use Class-File API

Reviewed-by: mgronlun

-------------

PR: https://git.openjdk.org/jdk/pull/16195


More information about the core-libs-dev mailing list