RFR: 8314891: Additional Zip64 extra header validation [v8]
Lance Andersen
lancea at openjdk.org
Mon Oct 23 19:12:57 UTC 2023
> Please review this PR which improves the Zip64 extra header validation:
>
> - Throw a ZipException If the extra len field is 0 and :
> -- size, csize, or loc offset are set to 0xFFFFFFFF
> -- disk starting number is set to 0xFFFF
>
> - We have a valid size for the Zip64 extra header but we are missing the csize or loc fields if they are expected to be part of the header
>
> Mach5 tiers 1-3 are clean
Lance Andersen has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains ten additional commits since the last revision:
- Merge branch 'master' into JDK-8314891
- Add missing space
- Revamp isZip64ExtBlockSizeValid
- Merge branch 'master' into JDK-8314891
- Merge branch 'master' into JDK-8314891
- Remove tab(s) from comment
- Added additional tests, along with additional cleanup and refactoring
- Clean up some minor formatting issues
- Additional Zip64 extra header validation
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/15650/files
- new: https://git.openjdk.org/jdk/pull/15650/files/208a5ecc..255aec85
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=15650&range=07
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=15650&range=06-07
Stats: 75854 lines in 1953 files changed: 44906 ins; 19381 del; 11567 mod
Patch: https://git.openjdk.org/jdk/pull/15650.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/15650/head:pull/15650
PR: https://git.openjdk.org/jdk/pull/15650
More information about the core-libs-dev
mailing list