RFR: JDK-8318476: Add resource consumption note to BigInteger and BigDecimal [v3]
Brian Burkhalter
bpb at openjdk.org
Mon Oct 23 20:09:37 UTC 2023
On Mon, 23 Oct 2023 03:50:50 GMT, Joe Darcy <darcy at openjdk.org> wrote:
>> Add informative notes to BigInteger and BigDecimal about possible running times, etc.
>
> Joe Darcy has updated the pull request incrementally with one additional commit since the last revision:
>
> Fix typo.
src/java.base/share/classes/java/math/BigDecimal.java line 302:
> 300: * scale. For example, an {@linkplain BigDecimal#multiply(BigDecimal)
> 301: * exact multiply} of two {@code BigDecimal} values is subject to the
> 302: * same {@linkplain BigInteger##algorithmicComplexity complexity
Does this link need two `##` or only one?
src/java.base/share/classes/java/math/BigInteger.java line 137:
> 135: * results indicate a multiply algorithm for numbers using this
> 136: * category of representation must run in <em>at least</em>
> 137: * <i>O</i>(<i>n</i> log <i>n</i>). Common multiply
"Common _multiply_" or "Common _multiplication_"?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16298#discussion_r1369211364
PR Review Comment: https://git.openjdk.org/jdk/pull/16298#discussion_r1369212528
More information about the core-libs-dev
mailing list