RFR: 8318613: ChoiceFormat patterns are not well tested [v2]
Naoto Sato
naoto at openjdk.org
Mon Oct 23 23:29:34 UTC 2023
On Mon, 23 Oct 2023 23:16:42 GMT, Justin Lu <jlu at openjdk.org> wrote:
>> Please review this PR which adds a test for ChoiceFormat intended to test a wide range of ChoiceFormat patterns.
>>
>> The existing test _Bug4387255_ only tests a singular basic pattern and does not test for incorrect patterns either.
>>
>> The new test checks
>>
>> - both correct and incorrect patterns
>> - the behavior of incorrect patterns that either throw an IllegalArgumentException or discard the incorrect portion
>> - the case of formatting with an empty pattern (that leads to empty limits and formats)
>
> Justin Lu has updated the pull request incrementally with one additional commit since the last revision:
>
> implement feedback
LGTM
-------------
Marked as reviewed by naoto (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/16324#pullrequestreview-1693680505
More information about the core-libs-dev
mailing list