RFR: 8318487: Specification of the ListFormat.equals() method can be improved [v2]
Joe Wang
joehw at openjdk.org
Tue Oct 24 17:07:48 UTC 2023
On Tue, 24 Oct 2023 17:05:29 GMT, Naoto Sato <naoto at openjdk.org> wrote:
>> Spec clarification of `ListFormat.equals()` method, utilizing newly introduced `getLocale()` and `getPatterns()`. A corresponding CSR has also been drafted.
>
> Naoto Sato has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains six commits:
>
> - Merge branch 'master' into JDK-8318487-ListFormat-equals
> - Fixing typo
> - Removed redundant wording
> - initial commit
> - Simplified the method spec
> - initial commit
Looks fine to me.
Alternatively (or more explicitly), it could be: Compares the specified object with this {@code ListFormat} for equality. Returns true if the given object is also a {@code ListFormat} and the two represent the same formats, specifically, if both {@code locale} and {@code patterns}, returned from {@link #getLocale()} and {@link #getPatterns()} respectively, are equal.
-------------
Marked as reviewed by joehw (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/16321#pullrequestreview-1695451108
More information about the core-libs-dev
mailing list