RFR: 8318486: Rename JavaLangAccess.xxNoRepl to xxReportError [v2]

Andrey Turbanov aturbanov at openjdk.org
Thu Oct 26 11:02:33 UTC 2023


On Fri, 20 Oct 2023 02:29:15 GMT, Chen Liang <liach at openjdk.org> wrote:

>> Please review a patch that renames `JavaLangAccess::xxNoRepl` to `xxReportError` to explicitly indicate these APIs report encoding errors.
>> 
>> The old "NoRepl" suffix presumably means "No Replacement", but it has been misunderstood as "No Replication" (#16209) and misused as an array sharing API in performance optimization patches.
>
> Chen Liang has updated the pull request incrementally with one additional commit since the last revision:
> 
>   NoRepl -> ReportError

src/java.base/share/classes/java/lang/System.java line 2476:

> 2474:                 return StringCoding.countPositives(bytes, offset, length);
> 2475:             }
> 2476:             public String newStringReportError(byte[] bytes, Charset cs) throws CharacterCodingException  {

Suggestion:

            public String newStringReportError(byte[] bytes, Charset cs) throws CharacterCodingException {

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16260#discussion_r1372975296


More information about the core-libs-dev mailing list