RFR: JDK-8317612: ChoiceFormat and MessageFormat constructors call non-final public method [v4]

[Lance Andersen]

On Fri, 27 Oct 2023 18:40:56 GMT, Justin Lu <jlu at openjdk.org> wrote:

>> Please review this PR which updates ChoiceFormat and MessageFormat to no longer call overridable methods in their constructors.
>> 
>> The overridable methods called in the constructors are: _ChoiceFormat::applyPattern_, _ChoiceFormat::setChoices_, and _MessageFormat::applyPattern_. The code should be updated so that both the methods and constructors call a separate private method. Some other drive-by cleanup changes were included in the change as well.
>
> Justin Lu has updated the pull request incrementally with one additional commit since the last revision:
> 
>   re-apply 'final' to the static methods in ChoiceFormat

Looks reasonable.  I assume you validated the links work in the generated docs as a sanity check

-------------

Marked as reviewed by lancea (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/16064#pullrequestreview-1702392861