RFR: 8316996: Catalog API Enhancement: add a factory method [v5]

Naoto Sato naoto at openjdk.org
Fri Oct 27 20:44:32 UTC 2023


On Fri, 27 Oct 2023 19:20:01 GMT, Joe Wang <joehw at openjdk.org> wrote:

>> Add a new factory method so that a CatalogResolver can be created with a resolve property on top of the Catalog object.
>
> Joe Wang has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Impl CSR Changes: change the parameter type from String to Enum

LGTM

src/java.xml/share/classes/javax/xml/catalog/CatalogResolver.java line 283:

> 281:                     return type;
> 282:                 }
> 283:             }

Instead of looping through all the elements, `Enum.valueOf()` can be used (and it appropriately throws IAE if not found).

-------------

Marked as reviewed by naoto (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/16045#pullrequestreview-1702510763
PR Review Comment: https://git.openjdk.org/jdk/pull/16045#discussion_r1375025707


More information about the core-libs-dev mailing list