RFR: 8303920: Avoid calling out to python in DataDescriptorSignatureMissing test [v8]
Eirik Bjorsnos
duke at openjdk.org
Sat Oct 28 20:01:56 UTC 2023
> Please review this PR which brings the DataDescriptorSignatureMissing test back to life.
>
> This test currently calls out to Python to create a test vector ZIP with a Data Descriptor without the recommended but optional signature. The Python dependency has turned out to be very brittle, so the test is currently marked with `@ignore`
>
> The PR replaces Python callouts with directly creating the test vector ZIP in the test itself. We can then remove the `@ignore`tag and run this useful test automatically.
Eirik Bjorsnos has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 10 commits:
- Merge branch 'master' into signature-less-data-descriptor
# Conflicts:
# test/jdk/java/util/zip/DataDescriptorSignatureMissing.java
- The END header LOC offset field and the second entry's CEN LOC offset fields need to be update to account for the four missing signature bytes.
- Merge branch 'master' into signature-less-data-descriptor
- Add assertNotNulls to catch unexpectedly missing entries
- Revert change to Google copyright line, add an Oracle copyright line instead.
- Use "Signatureless" consistently
- Remove reference to python in the @summary of DataDescriptorSignatureMissing
- Update copyright years
- Add method comments
- Instead of calling out to python, create a ZIP file and remove the data descriptor signature.
-------------
Changes: https://git.openjdk.org/jdk/pull/12959/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=12959&range=07
Stats: 134 lines in 1 file changed: 28 ins; 47 del; 59 mod
Patch: https://git.openjdk.org/jdk/pull/12959.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/12959/head:pull/12959
PR: https://git.openjdk.org/jdk/pull/12959
More information about the core-libs-dev
mailing list