RFR: 8304020: Speed up test/jdk/java/util/zip/ZipFile/TestTooManyEntries.java and clarify its purpose [v3]
Lance Andersen
lancea at openjdk.org
Mon Oct 30 14:32:49 UTC 2023
On Mon, 30 Oct 2023 12:13:59 GMT, Eirik Bjorsnos <duke at openjdk.org> wrote:
> > I think the changes look good overall. Thank you for this. I am not sure that the `@requires` is needed at this point.
>
> Was the `@requires (sun.arch.data.model == "64")` added to satisfy the 8GB memory requirement? If so, I guess we can safely remove the requires tag, even though the test still creates a ~2GB sparse file?
We would have to run across all of the mach5 platforms to verify. You could remove it for now and we go from here
-------------
PR Comment: https://git.openjdk.org/jdk/pull/12991#issuecomment-1785341362
More information about the core-libs-dev
mailing list