RFR: 8315454: Add an immutable BitSet

[Claes Redestad]

On Fri, 1 Sep 2023 08:21:13 GMT, Per Minborg <pminborg at openjdk.org> wrote:

> This PR proposes adding a new method to BitSet that provides an immutable snapshot of the set in the form of an `IntPredicate`.
> 
> The predicate is eligible for constant folding.
> 
> Here are some classes in the JDK that would benefit directly from constant-folding of BitSets:
> 
> PoolReader (6)
> URLEncoder (1) - Updated in this PR
> HtmlTree (2)
> 
> More over, the implementation of the predicate is @ValueBased and this would provide additional benefits in the future.
> 
> Initial benchmarks with the URLEncoder show encouraging results:
> 
> 
> Name                           (encodeChars) (maxLength) (unchanged) Cnt  Base   Error   Test   Error  Unit  Diff%
> URLEncodeDecode.testEncodeUTF8             6        1024           0  15 2,371 ± 0,016  2,073 ± 0,184 ms/op  12,6% (p = 0,000*)
> URLEncodeDecode.testEncodeUTF8             6        1024          75  15 1,772 ± 0,013  1,387 ± 0,032 ms/op  21,8% (p = 0,000*)
> URLEncodeDecode.testEncodeUTF8             6        1024         100  15 1,230 ± 0,009  1,140 ± 0,011 ms/op   7,3% (p = 0,000*)

While I think this minimal API could well prove to be a useful addition to many projects, this was conceived on a whim and while it's sufficient for `URLEncoder` and a few internal users, there's no evidence that this API fits the needs of third-party code. I'd be happy with an internal implementation initially.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/15530#issuecomment-1702576346