RFR: 5066247: Refine the spec of equals() and hashCode() for j.text.Format classes [v3]

Naoto Sato naoto at openjdk.org
Fri Sep 1 22:38:38 UTC 2023


On Fri, 1 Sep 2023 22:26:00 GMT, Justin Lu <jlu at openjdk.org> wrote:

>> Please review this PR which refines the spec of `equals()` and `hashCode()` in `java.text.Format` related classes.
>> 
>> The current spec for most of these methods is either  "_Overrides <method_name>_" or are incomplete/wrong (i.e. see `ChoiceFormat`).
>> 
>> This fix adjusts the spec to provide a consistent definition for the overridden methods and specify what is being compared/used to generate a hash code value.
>> 
>> For implementations that use at most a few fields, the values are stated, otherwise a more general term is used as a substitution (i.e. see `DecimalFormat`).
>
> Justin Lu has updated the pull request incrementally with one additional commit since the last revision:
> 
>   instanceof should not be camel case

Marked as reviewed by naoto (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/15459#pullrequestreview-1607727326


More information about the core-libs-dev mailing list