Withdrawn: 8180892: Correct handling of annotations on parameters

duke duke at openjdk.org
Mon Sep 4 10:23:08 UTC 2023


On Wed, 26 Apr 2023 04:34:34 GMT, Chen Liang <liach at openjdk.org> wrote:

> This patch aims to correct handling of annotations on parameters with the help of `MethodParameters` attribute, which will be always available once #9862 is integrated.
> 
> It utilizes and expands upon the existing parameter matching logic present in `Executable::getAllGenericParameterTypes`, and delegate parameter parameterized types, parameter annotation, and parameter type annotation accesses through the matched results, if matching is available. If matching failed, it falls back to existing heuristics that works without `MethodParameters` attributes for annotations, in `Executable::handleParameterNumberMismatch` and `TypeAnnotationParser::buildAnnotatedTypes` (renamed `buildAnnotatedTypesWithHeuristics` in this patch)
> 
> `ParameterMappingTest` covers these scenarios with class files that have `MethodParameters` or `Signature` attributes stripped or preserved to ensure the new Reflection API implementation works for both class files generated before #9862 and after its integration.
> 
> Also special thanks to Joe Darcy for reviewing 8304918 (#13183); this brings much convenience to this patch.

This pull request has been closed without being integrated.

-------------

PR: https://git.openjdk.org/jdk/pull/13664


More information about the core-libs-dev mailing list