RFR: 8314949: linux PPC64 Big Endian: Implementation of Foreign Function & Memory API [v7]
Jorn Vernee
jvernee at openjdk.org
Tue Sep 5 08:43:48 UTC 2023
On Mon, 4 Sep 2023 21:17:06 GMT, Martin Doerr <mdoerr at openjdk.org> wrote:
>> I've found a way to solve the remaining FFI problem on linux PPC64 Big Endian. Large structs (>8 Bytes) which are passed in registers or on stack require shifting the Bytes in the last slot if the size is not a multiple of 8. This PR adds the required functionality to the Java code.
>>
>> Please review and provide feedback. There may be better ways to implement it. I just found one which works and makes the tests pass:
>>
>> Test summary
>> ==============================
>> TEST TOTAL PASS FAIL ERROR
>> jtreg:test/jdk/java/foreign 88 88 0 0
>>
>>
>> Note: This PR should be considered as preparation work for AIX which also uses ABIv1.
>
> Martin Doerr has updated the pull request incrementally with one additional commit since the last revision:
>
> Add comments. Simplify condition.
Just some known failures in CI ([1]). So, this is good to go from my perspective.
[1]: https://bugs.openjdk.org/browse/JDK-8315646
-------------
Marked as reviewed by jvernee (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/15417#pullrequestreview-1610536541
More information about the core-libs-dev
mailing list