RFR: 8315578: PPC builds are broken after JDK-8304913 [v2]

Aleksey Shipilev shade at openjdk.org
Thu Sep 7 13:51:33 UTC 2023


On Thu, 7 Sep 2023 12:45:14 GMT, Martin Doerr <mdoerr at openjdk.org> wrote:

>> Yeah, we can technically change to `PPC32`. But the current thing follows what build system uses as `OPENJDK_TARGET_CPU` (`ppc`) and what would be used as `os.arch` because of that. So, choosing which way to deviate: towards build-system/java-props or towards hotspot macros, I think what current PR does is the lesser evil.
>
> One might expect `isPPC()` to return true on PPC64 because it technically is. This is the only drawback I see.

I don't have a strong opinion here, so if you want PPC32, you got it in new commit :)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15556#discussion_r1318636285


More information about the core-libs-dev mailing list