RFR: 8315578: PPC builds are broken after JDK-8304913 [v2]

Roger Riggs rriggs at openjdk.org
Thu Sep 7 14:09:43 UTC 2023


On Thu, 7 Sep 2023 13:51:31 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> Similar to other issues in the same area. I have no PPC32 machine to test the build on, but this matches other fixes for other architectures (https://github.com/openjdk/jdk/commit/83c096d6e20cd6e1164bc666df1be197a10431eb) after this fix the PPC32 Zero build completes fine.
>
> Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
> 
>  - Switch to PPC32
>  - Merge branch 'master' into JDK-8315578-ppc-builds
>  - Fix

src/java.base/share/classes/jdk/internal/util/PlatformProps.java.template line 62:

> 60:     static final boolean TARGET_ARCH_IS_LOONGARCH64 = "@@OPENJDK_TARGET_CPU@@" == "loongarch64";
> 61:     static final boolean TARGET_ARCH_IS_S390    = "@@OPENJDK_TARGET_CPU@@" == "s390";
> 62:     static final boolean TARGET_ARCH_IS_PPC32   = "@@OPENJDK_TARGET_CPU@@" == "ppc";

The list is getting longer.  I'd suggest/request that all the enums be resorted alphabetically.  (now or later).

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15556#discussion_r1318671548


More information about the core-libs-dev mailing list