RFR: 8315789: Minor HexFormat performance improvements [v2]
Claes Redestad
redestad at openjdk.org
Fri Sep 8 10:32:40 UTC 2023
> This PR seeks to improve formatting of hex digits using `java.util.HexFormat` somewhat.
>
> This is achieved getting rid of a couple of lookup tables, caching the result of `HexFormat.of().withUpperCase()`, and removing tiny allocation that happens in the `formatHex(A, byte)` method. Improvements range from 20-40% on throughput, and some operations allocate less:
>
>
> Name Cnt Base Error Test Error Unit Diff%
> HexFormatBench.appenderLower 15 1,330 ± 0,021 1,065 ± 0,067 us/op 19,9% (p = 0,000*)
> :gc.alloc.rate 15 11,481 ± 0,185 0,007 ± 0,000 MB/sec -99,9% (p = 0,000*)
> :gc.alloc.rate.norm 15 16,009 ± 0,000 0,007 ± 0,000 B/op -100,0% (p = 0,000*)
> :gc.count 15 3,000 0,000 counts
> :gc.time 3 2,000 ms
> HexFormatBench.appenderLowerCached 15 1,317 ± 0,013 1,065 ± 0,054 us/op 19,1% (p = 0,000*)
> :gc.alloc.rate 15 11,590 ± 0,111 0,007 ± 0,000 MB/sec -99,9% (p = 0,000*)
> :gc.alloc.rate.norm 15 16,009 ± 0,000 0,007 ± 0,000 B/op -100,0% (p = 0,000*)
> :gc.count 15 3,000 0,000 counts
> :gc.time 3 2,000 ms
> HexFormatBench.appenderUpper 15 1,330 ± 0,022 1,065 ± 0,036 us/op 19,9% (p = 0,000*)
> :gc.alloc.rate 15 34,416 ± 0,559 0,007 ± 0,000 MB/sec -100,0% (p = 0,000*)
> :gc.alloc.rate.norm 15 48,009 ± 0,000 0,007 ± 0,000 B/op -100,0% (p = 0,000*)
> :gc.count 15 0,000 0,000 counts
> HexFormatBench.appenderUpperCached 15 1,353 ± 0,009 1,033 ± 0,014 us/op 23,6% (p = 0,000*)
> :gc.alloc.rate 15 11,284 ± 0,074 0,007 ± 0,000 MB/sec -99,9% (p = 0,000*)
> :gc.alloc.rate.norm 15 16,009 ± 0,000 0,007 ± 0,000 B/op -100,0% (p = 0,000*)
> :gc.count 15 3,000 0,000 counts
> :gc.time 3 2,000 ms
> HexFormatBench.toHexLower 15 0,198 ± 0,001 0,119 ± 0,008 us/op 40,1% (p = 0,000*)
> :gc.alloc.rate 15 0,007 ± 0,000 0,007 ± 0,000 MB/sec -0,0% (p = 0,816 )
> :gc.alloc.rate.norm 15 0,001 ± 0,000 0,001 ± 0,000 B/op -40,1% (p = 0,000*)
> :gc.count 15 0,000 0,000 ...
Claes Redestad has updated the pull request incrementally with one additional commit since the last revision:
Add toHexDigitsByte|Short|Int|Long microbenchmarks
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/15591/files
- new: https://git.openjdk.org/jdk/pull/15591/files/59a1f609..c2393766
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=15591&range=01
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=15591&range=00-01
Stats: 26 lines in 1 file changed: 26 ins; 0 del; 0 mod
Patch: https://git.openjdk.org/jdk/pull/15591.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/15591/head:pull/15591
PR: https://git.openjdk.org/jdk/pull/15591
More information about the core-libs-dev
mailing list