RFR: 8315696: SignedLoggerFinderTest.java test failed

Daniel Fuchs dfuchs at openjdk.org
Fri Sep 8 14:24:38 UTC 2023


On Tue, 5 Sep 2023 20:06:41 GMT, Sean Coffey <coffeys at openjdk.org> wrote:

> Update the recently added LoggerFinder tests to cater for a possible condition where the test finishes before the boot logger executor service has flushed its pending data.
> 
> By simulating a slow thread in the ExecutorService used in BootstrapLogger, I was able to reproduce the issue described. Adding the `BootstrapLoggerUtils.awaitPending();` call allows the tests to pass.

LGTM!
Thanks for the update Seán.

-------------

Marked as reviewed by dfuchs (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/15571#pullrequestreview-1617603386


More information about the core-libs-dev mailing list