RFR: 8311207: Cleanup for Optimization for UUID.toString [v14]

Chen Liang liach at openjdk.org
Fri Sep 8 23:51:42 UTC 2023


On Fri, 8 Sep 2023 21:06:25 GMT, ExE Boss <duke at openjdk.org> wrote:

>> 温绍锦 has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   lo | hi => hi | lo
>
> src/java.base/share/classes/java/util/HexDigits.java line 66:
> 
>> 64:      */
>> 65:     @Stable
>> 66:     private static final short[] DIGITS;
> 
> Maybe it should be `char[]` instead since it’s encoded using unsigned 16‑bit integers.

a char would confuse people that each char represents one character, while it represents 2 in fact.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14745#discussion_r1320429120


More information about the core-libs-dev mailing list