RFR: 8285447: StackWalker minimal batch size should be optimized for getCallerClass [v2]

Mandy Chung mchung at openjdk.org
Mon Sep 11 17:34:42 UTC 2023


On Mon, 11 Sep 2023 12:18:42 GMT, Volker Simonis <simonis at openjdk.org> wrote:

>> Mandy Chung has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review feedback
>
> src/java.base/share/classes/java/lang/StackStreamFactory.java line 758:
> 
>> 756:          * So start the initial batch size with the minimum size.
>> 757:          * If it fetches the second batch, getCallerClass may be invoked via
>> 758:          * core reflection, can increase the next batch size.
> 
> This sentence reads strange to me. Maybe "If it fetches the second batch, getCallerClass may be invoked via core reflection, *so the next batch size will be increased.*"?

I updated and moved the comment to `batchSize` method.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15642#discussion_r1321863905


More information about the core-libs-dev mailing list