RFR: 8316050: Use hexadecimal encoding in MemorySegment::toString

Maurizio Cimadamore mcimadamore at openjdk.org
Mon Sep 11 22:31:42 UTC 2023


On Mon, 11 Sep 2023 21:17:27 GMT, Per Minborg <pminborg at openjdk.org> wrote:

> This PR proposes to use hexadecimal representation for a memory segment address rather than a decimal one.

Marked as reviewed by mcimadamore (Reviewer).

src/java.base/share/classes/jdk/internal/foreign/AbstractMemorySegmentImpl.java line 508:

> 506:     @Override
> 507:     public String toString() {
> 508:         return "MemorySegment{ heapBase: " + heapBase() + " address: 0x" + Long.toHexString(address()) + " limit: " + length + " }";

should we replace `limit` with `size` since we're here? (the javadoc says segments have size, not limit)

-------------

PR Review: https://git.openjdk.org/jdk/pull/15670#pullrequestreview-1620936858
PR Review Comment: https://git.openjdk.org/jdk/pull/15670#discussion_r1322131311


More information about the core-libs-dev mailing list