RFR: 8315810: Reimplement sun.reflect.ReflectionFactory::newConstructorForSerialization with method handles [v2]

Mandy Chung mchung at openjdk.org
Tue Sep 12 20:37:42 UTC 2023


On Tue, 12 Sep 2023 19:11:30 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

>> Mandy Chung has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>> 
>>  - Merge branch 'master' of https://github.com/openjdk/jdk into reflect-serializable-ctor
>>  - minor cleanup
>>  - Reimplement ReflectionFactory::newConstructorForSerialization with method handle
>
> src/java.base/share/classes/java/lang/invoke/MethodHandles.java line 3552:
> 
>> 3550:                 }
>> 3551:             }
>> 3552:             return false;
> 
> Does it break encapsulation too much to export and use the same method from jdk.internal.reflect.MethodHandleAccessorFactory.
> Maybe not worth it for a small utility method.

It's a small utility and I think it's ok to leave it this way.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15600#discussion_r1323533889


More information about the core-libs-dev mailing list