RFR: 8285447: StackWalker minimal batch size should be optimized for getCallerClass [v4]

Brent Christian bchristi at openjdk.org
Tue Sep 12 21:34:52 UTC 2023


On Tue, 12 Sep 2023 21:09:25 GMT, Mandy Chung <mchung at openjdk.org> wrote:

>> test/micro/org/openjdk/bench/java/lang/CallerClassBench.java line 45:
>> 
>>> 43: public class CallerClassBench {
>>> 44:     static final StackWalker INST = StackWalker.getInstance(StackWalker.Option.RETAIN_CLASS_REFERENCE);
>>> 45: 
>> 
>> Could `DROP_METHOD_INFO` also be used here?
>
> yes but it's irrelevant in this benchmark as `getCallerClass` should be independent to `DROP_METHOD_INFO` option.  The implementation always drops method info in the implementation.  It does not affect the result.

Ah - understood, thanks.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15642#discussion_r1323600936


More information about the core-libs-dev mailing list