RFR: 8314891: Additional Zip64 extra header validation [v2]

Lance Andersen lancea at openjdk.org
Thu Sep 14 15:57:48 UTC 2023


On Tue, 12 Sep 2023 08:47:03 GMT, Andrey Turbanov <aturbanov at openjdk.org> wrote:

>> Lance Andersen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Added additional tests, along with additional cleanup and refactoring
>
> test/jdk/java/util/zip/ZipFile/MissingZIP64EntriesTest.java line 198:
> 
>> 196:      * actual value is stored in the Zip64 Extra Header
>> 197:      */
>> 198:     private static final int  ZIP64_MAGICCOUNT = 0xFFFF;
> 
> Suggestion:
> 
>     private static final int ZIP64_MAGICCOUNT = 0xFFFF;

Removed the extra space.  thank you for pointing it out

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15650#discussion_r1326169219


More information about the core-libs-dev mailing list