RFR: 8316187: Modernize an example in StringTokenizer [v2]

[Naoto Sato]

On Fri, 15 Sep 2023 18:06:10 GMT, Pavel Rappo <prappo at openjdk.org> wrote:

>> This modernizes an example to use the extended for-statement introduced in JDK 1.5.
>> 
>> I understand that StringTokenizer is a legacy class. But legacy or not, a class shouldn't promote older constructs when newer fit better. Especially when advising on preferred alternatives to itself.
>> 
>> That said, I wouldn't go as far as to use `var` anywhere in that example: JDK 10, which introduced `var`, might still be relatively new to some. Nor would I inline the call to `String.split` in the for-statement to dispense with the `String[] result` variable: I reckon it's good for a reader unfamiliar with `String.split` to see the type it returns.
>> 
>> Perhaps one additional thing to ponder is this: we could either add `@see` to point to `String.split` or make the whole example a `@snippet`, which `@link`s code to the definition of `String.split`.
>
> Pavel Rappo has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Tag on a few more cases

Still LGTM. Good point to use `var` for making it type agnostic.

-------------

Marked as reviewed by naoto (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/15716#pullrequestreview-1629492143