RFR: 8314891: Additional Zip64 extra header validation [v6]

Lance Andersen lancea at openjdk.org
Mon Sep 18 13:12:31 UTC 2023


> Please review this PR which improves the Zip64 extra header validation:
> 
> - Throw a ZipException If the extra len field is 0 and :
> -- size, csize, or loc offset are set to 0xFFFFFFFF
> -- disk starting number is set to 0xFFFF
> 
> - We have a valid size for the Zip64 extra header but we are missing the csize or loc fields if they are expected to be part of the header
> 
> Mach5 tiers 1-3 are clean

Lance Andersen has updated the pull request incrementally with one additional commit since the last revision:

  Revamp isZip64ExtBlockSizeValid

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/15650/files
  - new: https://git.openjdk.org/jdk/pull/15650/files/f64a70c3..bbc5325d

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=15650&range=05
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=15650&range=04-05

  Stats: 61 lines in 3 files changed: 14 ins; 13 del; 34 mod
  Patch: https://git.openjdk.org/jdk/pull/15650.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/15650/head:pull/15650

PR: https://git.openjdk.org/jdk/pull/15650


More information about the core-libs-dev mailing list