RFR: 8268829: Provide an optimized way to walk the stack with Class object only [v12]

Mandy Chung mchung at openjdk.org
Mon Sep 18 16:46:00 UTC 2023


On Sun, 17 Sep 2023 07:42:43 GMT, Chen Liang <liach at openjdk.org> wrote:

>> src/java.base/share/classes/java/lang/StackFrameInfo.java line 93:
>> 
>>> 91:         synchronized (this) {
>>> 92:             if (type instanceof String sig) {
>>> 93:                 type = JLIA.getMethodType(sig, declaringClass().getClassLoader());
>> 
>> Maybe there should be a `return` here:
>> Suggestion:
>> 
>>                 return type = JLIA.getMethodType(sig, declaringClass().getClassLoader());
>
> `type` is of type `Object`, don't think this compiles as the result type of `=` is the `type` variable's type.

You missed line 96 where `type` is returned.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15370#discussion_r1329010705


More information about the core-libs-dev mailing list