RFR: 8313612: Use JUnit in lib-test/jdk tests [v3]
Chen Liang
liach at openjdk.org
Tue Sep 19 10:10:44 UTC 2023
On Thu, 7 Sep 2023 07:15:06 GMT, Qing Xiao <xqoasis at openjdk.org> wrote:
>> Modified all tests under lib-test/jdk to use JUnit
>
> Qing Xiao has updated the pull request incrementally with one additional commit since the last revision:
>
> Change test static method to instance method
test/lib-test/jdk/test/lib/hexdump/HexPrinterTest.java line 214:
> 212: }
> 213:
> 214: // PrimitiveFormatters
This comment is now useless.
Suggestion:
test/lib-test/jdk/test/lib/hexdump/ObjectStreamPrinterTest.java line 90:
> 88: }
> 89:
> 90: // SingleObjects
Suggestion:
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15131#discussion_r1329887061
PR Review Comment: https://git.openjdk.org/jdk/pull/15131#discussion_r1329888251
More information about the core-libs-dev
mailing list