RFR: 8315960: test/jdk/java/io/File/TempDirDoesNotExist.java leaves test files behind [v5]
Brian Burkhalter
bpb at openjdk.org
Tue Sep 19 21:26:40 UTC 2023
On Tue, 19 Sep 2023 21:17:02 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:
>> test/jdk/java/io/File/TempDirDoesNotExist.java line 118:
>>
>>> 116: }
>>> 117:
>>> 118: public static Stream<Arguments> nonexistentProvider() {
>>
>> The `nonexistentProvider` seems like an odd name. The only provider here is the junit provider (not a FileSystem provider)
>> How about `NoTempDir` and `TempDir` for the two argument streams.
>
> That definitely sounds more reasonable. Unfortunate nomenclature on my part.
I think maybe instead "tempDirSource' and "noTempDirSource."
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15757#discussion_r1330720489
More information about the core-libs-dev
mailing list