RFR: 8316540: StoreReproducibilityTest fails on some locales

Jaikiran Pai jpai at openjdk.org
Wed Sep 20 05:13:45 UTC 2023


On Tue, 19 Sep 2023 22:49:36 GMT, Naoto Sato <naoto at openjdk.org> wrote:

> Fixing a test case that fails in some time zones. Making sure the test is run in `UTC` zone will fix the issue. Confirmed the fix by manually setting machine's time zone to Europe/Dublin.

Hello Naoto,  the use of `UTC` looks good to me. Since the failing `assertCurrentDate()` method is only called in `testEmptySysPropValue()`, should we perhaps limit this usage of `UTC` timezone to only that test?  The rest of test methods just verify that whatever value was passed to the `java.properties.date` system property was written out as a comment in the properties file and they don't assert any `Date` semantics.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/15829#issuecomment-1726978731


More information about the core-libs-dev mailing list