RFR: 8316493: Make immutable maps @ValueBased [v2]

Chen Liang liach at openjdk.org
Wed Sep 20 07:27:42 UTC 2023


On Wed, 20 Sep 2023 06:04:26 GMT, Per Minborg <pminborg at openjdk.org> wrote:

>> This PR outlines a solution for making immutable maps `@ValueBased` by removing cacheing of certain values in `AbstractMap`.
>> 
>> By removing these caching fields in `AbstractMap`, we can make the immutable maps `@ValueBased` and at the same time, performance is likely improved because the JVM is probably able to optimize away object creation anyway via escape analysis. Also, all maps will occupy less space as we get rid of a number of objects and references stored for each map.
>> 
>> We need to benchmark this solution to better understand its implications.
>
> Per Minborg has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove redundant impl spec parts

We might need a CSR for the removal of `@implSpec` and equality behavior that @ExE-Boss described.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/15614#issuecomment-1727119718


More information about the core-libs-dev mailing list