RFR: 8315960: test/jdk/java/io/File/TempDirDoesNotExist.java leaves test files behind [v8]

[Daniel Jeliński]

On Wed, 20 Sep 2023 21:51:19 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:

>> Add a `finally` block to delete the created files.
>
> Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8315960: Address additional reviewer comments

Now that we're using junit, we can start using assertions

test/jdk/java/io/File/TempDirDoesNotExist.java line 142:

> 140:         OutputAnalyzer originalOutput = ProcessTools.executeTestJvm(options);
> 141:         List<String> list = originalOutput.asLines().stream().filter(line
> 142:                 -> line.equalsIgnoreCase(WARNING)).toList();

You could use `count` instead of `toList`; the actual list is never used in this test

test/jdk/java/io/File/TempDirDoesNotExist.java line 143:

> 141:         List<String> list = originalOutput.asLines().stream().filter(line
> 142:                 -> line.equalsIgnoreCase(WARNING)).toList();
> 143:         if (list.size() != 1)

Use assertEquals

test/jdk/java/io/File/TempDirDoesNotExist.java line 148:

> 146:                                        originalOutput.asLines().toString());
> 147:         int exitValue = originalOutput.getExitValue();
> 148:         if (exitValue != 0)

Use assertEquals

-------------

PR Review: https://git.openjdk.org/jdk/pull/15757#pullrequestreview-1636914632
PR Review Comment: https://git.openjdk.org/jdk/pull/15757#discussion_r1332479846
PR Review Comment: https://git.openjdk.org/jdk/pull/15757#discussion_r1332474537
PR Review Comment: https://git.openjdk.org/jdk/pull/15757#discussion_r1332474679