RFR: 8316587: Use ArraysSupport.vectorizedHashCode in Utf8EntryImpl [v2]

Chen Liang liach at openjdk.org
Thu Sep 21 09:35:42 UTC 2023


On Thu, 21 Sep 2023 02:38:08 GMT, Chen Liang <liach at openjdk.org> wrote:

>> Like #12077, this uses JDK's internal utilities to speed up ASCII reading in Class files, where most identifiers, from conventions to attribute names, are ASCII. See the JBS issue for more in-depth explanations.
>> 
>> Before: (Master)
>> 
>> Benchmark                         Mode  Cnt    Score   Error  Units
>> ReadMetadata.jdkReadMemberNames  thrpt    4  167.623 ± 8.522  ops/s
>> 
>> 
>> After: (This patch, first revision)
>> 
>> Benchmark                         Mode  Cnt    Score   Error  Units
>> ReadMetadata.jdkReadMemberNames  thrpt    4  175.908 ± 4.766  ops/s
>
> Chen Liang has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix logical bug with char array filling

@asotona Since this is your area, can you take a look?
@cl4es Can you review this as well since you are more professional in string optimizations, and can you see if you have similar performance improvements?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/15837#issuecomment-1729209220


More information about the core-libs-dev mailing list